-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WEBSOCKET]: Initial Implementation #1415
base: main
Are you sure you want to change the base?
Conversation
Will continue to upgrade to support channels using |
94bb2d4
to
b6468c7
Compare
REBASED |
634df8c
to
16dea9f
Compare
@amadolid Looking at this and have some question:
|
Also, I think we are going to need a different type of documentation on this. We need to include end-to-end examples, like what fastAPI has https://fastapi.tiangolo.com/advanced/websockets/#await-for-messages-and-send-messages. We need maybe 3 common use case:
|
if ( | ||
authorization := websocket.headers.get("Authorization") | ||
) and authorization.lower().startswith("bearer"): | ||
token = authorization[7:] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a nitpick: I'd use len("bearer")
instead of 7
. A bit more readable.
@@ -0,0 +1,44 @@ | |||
"""Sample Runner.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm is this a helper script? do we need to commit this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be good example for deploying using uvicorn
Agree, tho the sample insomnia export has the complete use case including the request examples. Might need to convert it to docs type |
Yeah but the insomnia doesn't include the server side implementation. |
FEATURES
:WEBSOCKET
Walker Declaration
Websocket Connection
Client Valid Events
Walker
User
Channel
Client
Walker Client Notification
PREREQUISITE
Self
User
Channel
Client