Fixing minor issues in Tutorial EECS449 #1314
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TharukaCkasthuri
added
documentation
ChrisIsKing
requested changes
Oct 4, 2024
jac/support/jac-lang.org/docs/learn/tutorial/2_building-a-rag-chatbot.md
Outdated
Show resolved
Hide resolved
jac/support/jac-lang.org/docs/learn/tutorial/2_building-a-rag-chatbot.md
Outdated
Show resolved
Hide resolved
jac/support/jac-lang.org/docs/learn/tutorial/2_building-a-rag-chatbot.md
Outdated
Show resolved
Hide resolved
jac/support/jac-lang.org/docs/learn/tutorial/2_building-a-rag-chatbot.md
Outdated
Show resolved
Hide resolved
| has chat_history: list[dict]; | ||
|
|
||
| can init_router with `root entry { | ||
| visit [-->](`?Router) else { |
There was a problem hiding this comment.
@TharukaCkasthuri Make a modification here that caters for if the router node is already present but all the chat types are not. In the class we asked students to create a new chat type node for themselves and they struggled to add it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description