-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
trailing comma support implemented #1272
Conversation
ThakeeNathees
commented
Sep 11, 2024
6fca511
to
e14e509
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good overall @ThakeeNathees 🎯. However, it would be great if we could extend support for trailing commas to tuples as well: @marsninja
(1, 2, 3,);
a19e00b
to
c8d75d8
Compare
c8d75d8
to
86693a9
Compare
Hi @AshishMahendra , the recent grammar change introducing trailing commas is causing the formatter to break, particularly in the FuncCall handling. The IndexError: list index out of range seems to occur when processing the trailing commas. Could you please look into fixing this in the same PR?
Link to the Test file |