Skip to content

Commit

Permalink
Update to .NET 8
Browse files Browse the repository at this point in the history
This is only relevant for contributors. Nothing changes for users.

The tests are currently failing however because of
[TINKERPOP-3029](https://issues.apache.org/jira/browse/TINKERPOP-3029).
So, we'll have to wait for Gremlin.Net 3.7.2 here.

Signed-off-by: Florian Hockmann <[email protected]>
  • Loading branch information
FlorianHockmann committed Jan 31, 2024
1 parent 7aa947f commit c22c836
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/dotnet.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
- name: Setup .NET
uses: actions/setup-dotnet@v4
with:
dotnet-version: 6.0.x
dotnet-version: 8.0.x
- name: Install dependencies
run: "dotnet restore"
- name: Build
Expand Down Expand Up @@ -66,6 +66,6 @@ jobs:
- name: Setup .NET
uses: actions/setup-dotnet@v4
with:
dotnet-version: 6.0.x
dotnet-version: 8.0.x
- name: Push to NuGet Feed
run: dotnet nuget push './artifacts/*.nupkg' --skip-duplicate --source "$NUGET_FEED" --api-key "$NUGET_KEY"
4 changes: 2 additions & 2 deletions BUILDING.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ JanusGraph.Net uses dotnet build for convenient builds across platforms.

## Requirements

* [.NET 6.0 SDK (version >= 2.1.400)][dotnet-sdk] is needed to build and test the project.
* [.NET 8.0 SDK][dotnet-sdk] is needed to build and test the project.
* [Docker][docker] needs to be running in order to execute the integration tests as they automatically start a
JanusGraph Docker container.

Expand Down Expand Up @@ -43,6 +43,6 @@ successfully.
The version number used for the tag should correspond to the version in the
`.csproj` file as that version is used for the NuGet package.

[dotnet-sdk]: https://dotnet.microsoft.com/en-us/download/dotnet/6.0
[dotnet-sdk]: https://dotnet.microsoft.com/en-us/download/dotnet
[docker]: https://www.docker.com/
[git-tag]: https://git-scm.com/book/en/v2/Git-Basics-Tagging
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>net6</TargetFramework>
<TargetFramework>net8.0</TargetFramework>
<IsPackable>false</IsPackable>
</PropertyGroup>
<ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>net6</TargetFramework>
<TargetFramework>net8.0</TargetFramework>
<IsPackable>false</IsPackable>
</PropertyGroup>
<ItemGroup>
Expand Down

0 comments on commit c22c836

Please sign in to comment.