Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few bugs about io #2252

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix a few bugs about io #2252

wants to merge 4 commits into from

Conversation

Hydrop002
Copy link

  • When importing a bedrock model, if there are both locators with rotation and without rotation in the same group, those locators without rotation may incorrectly get rotated.
    e.g.
{
	"name": "bone",
	"pivot": [0, 0, 0],
	"locators": {
		"locator": {
			"offset": [0, 0, 0],
			"rotation": [-20, -35, 60]
		},
		"locator2": [0, 0, 0]
	}
}
  • Parsing of modded_entity always encounter problems, such as bone rotation problem caused by addChild out of order. So I improved it a little bit. I haven't considered model formats for versions of 1.17+ because I haven't read the code for those versions yet.

@JannisX11
Copy link
Owner

The locator issue is a good catch 👍
Will look at the modded entity import code another time. This feature is no longer supported for more recent versions, so it is more or less deprecated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants