Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Raycasting for selectability of foreground objects only #2052

Open
wants to merge 6 commits into
base: next
Choose a base branch
from

Conversation

farfalk
Copy link
Contributor

@farfalk farfalk commented Oct 9, 2023

This is meant as an enhancement of #2028, as it's mostly useful for batch selection of vertices and faces; but because that is a fix and this is a feature proposal, here we are.

If the wireframe mode is enabled, everything becomes selectable.

Check the video below (notice that #2028 is also in use)

8mb.video-sgg-YIjx4pGG.mp4

@netlify
Copy link

netlify bot commented Oct 9, 2023

Deploy Preview for blockbench-dev ready!

Name Link
🔨 Latest commit f62d59f
🔍 Latest deploy log https://app.netlify.com/sites/blockbench-dev/deploys/652d0ae9e9f37000084dec75
😎 Deploy Preview https://deploy-preview-2052--blockbench-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@farfalk farfalk changed the title WIP: Raycasting for selectability of foreground objects only Draft: Raycasting for selectability of foreground objects only Oct 9, 2023
@farfalk
Copy link
Contributor Author

farfalk commented Oct 9, 2023

This is a Draft because:

  1. slows down A LOT with some meshes
  2. in some cases it fails to select foreground faces

Check video below for an example of both problems

8mb.video-xP5-mdmlyyWe.mp4

@JannisX11 have you got any suggestion?

@farfalk
Copy link
Contributor Author

farfalk commented Oct 15, 2023

Both issues are solved with the latest commit.
I still think performance could be improved a bit more, but there's already no comparison with the previous version. On my machine, selection with lots of objects takes away about 5-10 fps max

@farfalk
Copy link
Contributor Author

farfalk commented Feb 21, 2024

@JannisX11 is this interesting to you? If so, do you have any hint about how to proceed in terms of performance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant