Implemented Method to Allow File to be Relinked if the User Moved the File, Added Tests to Test the Method #12110
+160
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…by Le-Chat-BottE)
…h file name changing workaround to account for the faulty filteringFunction method in CitationKeyBasedFileFinder.java (Co-authored by Le-Chat-BottE)
…eFileFromSubfolderToRootFolder, relinkMoveFileFromSubfolderToSubfolder, noRelinkCopyFileFromRootFolderToSubfolder, noRelinkCopyFileFromSubfolderToRootFolder, noRelinkCopyFileFromSubfolderToSubfolder) in AutoSetFileLinksUtilTest.java (Co-authored by Le-Chat-BottE)
…fix-for-koppor-issue-9798 # Conflicts: # src/test/java/org/jabref/gui/externalfiles/AutoSetFileLinksUtilTest.java
…s improvement on issue [JabRef#9798](JabRef#9798)
…s improvement, automatically relink a file if it is moved. On issue [JabRef#9798](JabRef#9798)
…fix-for-koppor-issue-9798
koppor
requested changes
Oct 27, 2024
| // If file that is already linked to an existing entry is moved, the file should be relinked to the entry | ||
| private void relinkFileIfMoved(List<LinkedFile> newLinkedFiles, BibEntry entry) { | ||
| // Get the list of files linked to a specific entry | ||
| List<LinkedFile> allLinkedFiles = entry.getField(StandardField.FILE).map(FileFieldParser::parse).orElse(Collections.emptyList()); |
|
Hey @u7754676 |
u7754676
changed the title
koppor
added
the
status: changes required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix was co-written by Le-Chat-BottE and I. We have implemented the "Automatically set file links" feature. Specifically, this was the implementation described under the heading "First Implementation" in the original issue #9798. Our implementation comes in the form of the addition of the new method relinkFileIfMoved in the AutoSetFileLinks.java file.
In addition, as requested in the issue itself, we have also created 6 new tests to test this new method, located in the AutoSetFileLinksUtilTest.java file. The 6 tests are as follows:
We think our code is ready for review and we welcome any feedback or suggestions. Thank you!
Fixes #9798.
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)