Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Tabular UI and Backend Logic for Linked Files Pattern List Configuration #11368 #12090

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Commits on Oct 18, 2024

  1. Implement core logic for Linked Files Patterns list Configuration UI

    This commit lays the groundwork for a tabular UI to configure filename
    patterns for linked files. The core logic is implemented, mirroring the
    structure used for Citation Key Patterns. UI implementation and integration
    with LinkedFilesTab will be addressed in later commits.
    naaeeen-Anu committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    35aeef5 View commit details
    Browse the repository at this point in the history
  2. Implement additional logic for Linked Files Patterns list Configurati…

    …on UI
    
    This commit replace the old ui with tabular UI to configure filename
    patterns for linked files. The core logic is implemented, mirroring the
    structure used for Citation Key Patterns. UI implementation and integration
    with LinkedFilesTab will be addressed in later commits.
    naaeeen-Anu committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    7524e89 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2024

  1. Refactor file name pattern handling in LinkedFilesTab

    This commit improves the UI and makes it functional. However, core logic still needs to be implemented.
    
    IMPORTANT TODO:
    1. Update CleanupPresetPanel.java in gui/cleanup:
       - Temporarily added .toString() to filePreferences.getFileNamePattern()
       - Need to modify this as the new GlobalFilenamePattern object stores patterns
         for different file types, not just a single pattern
    
    2. Refactor getSuggestedFileName in logic/externalfiles/LinkedFileHandler.java:
       - Current implementation expects a single file name pattern
       - Need to update to work with the new GlobalFilenamePattern object
    
    Note: These changes may affect other parts of the application that rely on
    the previous file name pattern implementation. Further testing and updates
    may be required.
    naaeeen-Anu committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    2d267e5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7238046 View commit details
    Browse the repository at this point in the history
  3. Refactor file name pattern handling in LinkedFilesTab

    This commit improves the UI and makes it functional. However, core logic still needs to be implemented.
    
    IMPORTANT TODO:
    1. Update CleanupPresetPanel.java in gui/cleanup:
       - Temporarily added .toString() to filePreferences.getFileNamePattern()
       - Need to modify this as the new GlobalFilenamePattern object stores patterns
         for different file types, not just a single pattern
    
    2. Refactor getSuggestedFileName in logic/externalfiles/LinkedFileHandler.java:
       - Current implementation expects a single file name pattern
       - Need to update to work with the new GlobalFilenamePattern object
    
    Note: These changes may affect other parts of the application that rely on
    the previous file name pattern implementation. Further testing and updates
    may be required.
    naaeeen-Anu committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    ef1bfd1 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2024

  1. Implement Comprehensive Filename Logic Based on Entry Type in FileUtil

    Major change:
    - Refactored `createFileNameFromPattern` in `FileUtil` to generate filenames dynamically based on the `EntryType`.
    - Add store and load for FilePreferences
    **Note:** Related test cases currently encounter compile errors and require fixes.
    naaeeen-Anu committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    432f738 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e4ff16f View commit details
    Browse the repository at this point in the history
  3. improve style

    naaeeen-Anu committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    3719079 View commit details
    Browse the repository at this point in the history
  4. improve style

    naaeeen-Anu committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    33dddfd View commit details
    Browse the repository at this point in the history
  5. Merge pull request #4 from Naaeeen/linked-files-pattern-logic-#2

    Linked files pattern logic and UI #1 #2
    Naaeeen authored Oct 26, 2024
    Configuration menu
    Copy the full SHA
    8e0b7d8 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e3daddc View commit details
    Browse the repository at this point in the history