Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release plugin for sonatype #13

Merged
merged 15 commits into from
May 21, 2024
Merged

Update release plugin for sonatype #13

merged 15 commits into from
May 21, 2024

Conversation

Siedlerchr
Copy link
Member

TODO: add creds to github secrets etc

build.gradle Outdated Show resolved Hide resolved
build.gradle Outdated Show resolved Hide resolved
build.gradle Show resolved Hide resolved
@koppor
Copy link
Member

koppor commented May 20, 2024

> Could not get unknown property 'ossrhUsername' for Credentials [username: null] of type org.gradle.internal.credentials.DefaultPasswordCredentials_Decorated.

@Siedlerchr Could you have a look? (Sorry for not having followed up earlier on this)

@Siedlerchr
Copy link
Member Author

I will try to take a look at the next days...
The above state was for doing a release locally.

@Siedlerchr Siedlerchr self-assigned this May 20, 2024
@koppor
Copy link
Member

koppor commented May 21, 2024

Background why we dived into this one: We think, we need to rewrite the part of FXML loading due to oracle/graal#7682, which requires to use Stream instead of Path for a "clean" loading from files stored inside an application distribution.

@Siedlerchr Siedlerchr requested a review from koppor May 21, 2024 18:01
@koppor koppor merged commit 4347d44 into main May 21, 2024
4 checks passed
@koppor koppor deleted the testRelease branch May 21, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants