Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per Node Dashboard and .cfg stat groups #53

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

clamalfa
Copy link

Updated dashboards and edited the .cfg file adding in per node stat groups

@clamalfa clamalfa closed this Jun 12, 2018
@clamalfa clamalfa deleted the connor_IDC_6_11 branch June 12, 2018 01:33
@clamalfa clamalfa restored the connor_IDC_6_11 branch June 12, 2018 01:33
@clamalfa clamalfa reopened this Jun 12, 2018
@clamalfa clamalfa changed the title Connor IDC 6 11 Per Node Dashboard and .cfg stat groups Jun 12, 2018
@tenortim
Copy link
Collaborator

tenortim commented Jan 1, 2020

Sorry for the huge delay in reviewing (I took far too long chasing down access).
Several changes need to be made.

  1. All of the JPG/png files were deleted. These are referenced in README.md and need to be restored or updated.
  2. All of the dashboards were deleted and new ones created because of the name change. I have no problem dropping the "grafana_" part of the name, but the files need to be "git mv"ed so that the history is retained and we can see the diff rather than a complete new file.
  3. isi_data_insights_d.cfg seems to have been added. The source should only contain the example version so that the end user is forced to copy and edit the example config.

Copy link
Collaborator

@tenortim tenortim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per the conversation, need to make changes here.
The .JPG,.png files are referenced from README.md and need to be restored or updated.
The json files need to be "git mv"ed if they're renamed. Currently, they're deleted and new ones added which loses all the history and doesn't show the changes.
isi_data_insights_d.cfg seems to have been added. That shouldn't be part of the source tree. Part of configuring the collector is to copy the example file and edit it. If there are changes, they need to be made to the example config file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants