Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dotnet tool to .NET 8 #1834

Merged
merged 2 commits into from
Dec 14, 2024
Merged

Bump dotnet tool to .NET 8 #1834

merged 2 commits into from
Dec 14, 2024

Conversation

slozier
Copy link
Contributor

@slozier slozier commented Dec 8, 2024

Since .NET 6 is no longer supported...

@slozier
Copy link
Contributor Author

slozier commented Dec 12, 2024

There's a bunch of errors on the github actions net8.0 tests. I think I saw these locally at some point, but now they're gone and I haven't been able to reproduce:

Could not load file or assembly 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'

@BCSharp
Copy link
Member

BCSharp commented Dec 12, 2024

OK, I'll test it locally as well. Lately I've lost confidence in the results of CI tests.

@BCSharp
Copy link
Member

BCSharp commented Dec 13, 2024

I can't figure it out. I am getting

System.IO.FileLoadException: Could not load file or assembly 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The located assembly's manifest definition does not match the assembly reference.

every single time and can't get it to work. Maybe something sits in the cache that throws off the process. Or maybe something is missing in the cache.

@slozier
Copy link
Contributor Author

slozier commented Dec 14, 2024

Ok, I guess it was the runtimeconfig file. Not sure why it wasn't an issue on Azure. 😕

@BCSharp
Copy link
Member

BCSharp commented Dec 14, 2024

Yes! it works now locally for me. runtimeconfig makes total sense.

@slozier slozier merged commit a0f828f into IronLanguages:main Dec 14, 2024
5 of 8 checks passed
@slozier slozier deleted the net8 branch December 14, 2024 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants