-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub: Simplify root directory and migrate documentation #1812
base: main
Are you sure you want to change the base?
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
@slozier would you mind reviewing this PR when you get a moment? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Seeing community PRs definitely helps motivate me to work on the project.
I'm not sure how I feel about using the wiki for documentation. The biggest drawbacks for me would be:
- The content is not visible in the cloned repo so I tend to neglect it. For example if I want to drop support for .NET 6 (which is no longer supported by Microsoft) I usually search though files to find relevant things to change.
- Can't keep different branches of documentation, for example
main
and3.6
could have differentPackage Compatibility
orWhat's New
pages. Although it looks like in practice I haven't done that.
@BCSharp I know you played with the documentation a bit. Any thoughts or concerns?
@@ -0,0 +1,72 @@ | |||
name: Bug Report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although I like the idea of better structured bug reports I'm not sure this set of templates is well suited for the project. I assume this lets you pick a style before proceeding to filing an issue? Is there an escape hatch that allows not using a template?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a way to still use blank issues, it can be enabled from the config.yml
file I created. I'll enable it now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems generally fine. Will probably need to adjust the issue templates some more but it's a good start.
Looks like renaming LICENSE might have broken the packaging step.
Oh hmm, perhaps we should not be renaming the LICENSE file. The license notice at the top of every file says:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The NuGet package built-in README will need to be changed as well, since NuGet isn't using the latest of MarkDig and doesn't support more recent GitHub Markdown like info bars.
What's wrong with the NuGet package README? I guess some of the URLs will have to change, but I don't think it needs substantial changes. |
@Lamparter, I am enthusiastic to see an enthusiastic contributor!
I am very positive about moving the documentation to the GitHub wiki. Actually, I was planning to do it myself at some point, but never got to finish it. Over the years, I would clean up the old wiki (moving any useful info to the checked in docs), hoping for one day to put it to good use. Writing However, @slozier, I share your concerns about the move; here is how I see them:
|
It will break on NuGet |
won't matter after IronLanguages#1812
Alright, what's the plan with this one? I'm fine with moving docs to the wiki as well as the github issue templates. I'd like to keep the "what's new" files in the repo as I consider them more like developer checklists than documentation. |
Where do you want them to go? The Documentation folder? |
Thought this removed everything from Documentation? Can't think of a good spot though so wherever works for you. |
I think |
I'm fine with either one. Probably leaning towards @slozier , are you OK with Features out of the repo? |
The feature symbols you mean? They're more of a dev reference and not something a user would care about. Would fit in with |
They might be easier to edit and reference if they were in the wiki. |
I'm an enthusiastic user of IronPython and have been for years... it's sad to see the last commit to main being nearly six months ago!
In this PR I've taken the effort to simplify the root directory and make some other few contributions in an effort to hopefully revive the work on this project to that of a big, ambitious project that IronPython is.