Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is that the
PythonType._subtypes
list (which is used for the__subclasses__
method) is growing every time a new subclass is created and not getting cleaned up as types get GCd. This is not actually a regression with ipy2, if you swap the class definitions with new-style classes then it also fails there.I'm not super happy with the perf impact of this solution but I'm not sure what else to do (other than adding a finalizer to PythonType). @BCSharp any other ideas?
Resolves #508