Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for missing trace event on first expression #281

Merged
merged 4 commits into from
Nov 27, 2024

Conversation

slozier
Copy link
Contributor

@slozier slozier commented Nov 27, 2024

This should resolve the issue from IronLanguages/ironpython3#1810 where the first trace event is not getting generated.

@slozier slozier merged commit ce7ce74 into IronLanguages:main Nov 27, 2024
8 checks passed
@slozier slozier deleted the debuginfo branch November 27, 2024 02:27
@slozier
Copy link
Contributor Author

slozier commented Nov 27, 2024

Reverting this. Will need more testing...

slozier added a commit that referenced this pull request Nov 27, 2024
@BCSharp
Copy link
Member

BCSharp commented Nov 27, 2024

I suppose the build/packaging fixes will go through a separate PR?

@slozier
Copy link
Contributor Author

slozier commented Nov 27, 2024

I suppose the build/packaging fixes will go through a separate PR?

I ended up doing a push to main (yes I know it's bad) for the revert instead of going through the github revert mechanism. The build/packaging fixes should be on the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants