Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid ToLoverInvariant in string comparisons (CA1862) #279

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

BCSharp
Copy link
Member

@BCSharp BCSharp commented Dec 10, 2023

Resolves some warnings-turned-errors.

Copy link
Contributor

@slozier slozier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me although I'm thinking it would be better if these were OrdinalIgnoreCase?

@BCSharp
Copy link
Member Author

BCSharp commented Dec 11, 2023

I suppose you're right, OrdinalIgnoreCase should be faster.

@slozier slozier merged commit 872730a into IronLanguages:master Dec 11, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants