Skyblock Generator 2: Electric Boogaloo #933
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated generators to allow server owners to set the default biome and whether they'd like their oceans to be decorated or not (includes ores, deposits, and geodes, no caves)
cleaned up some residual das code
uh so we basically create a duplicate of the world on first generation of an island that will then be used to copy and paste the terrain under the islands the first generation is slow because it has to create the worlds, but once this is done its exactly like the deleting blocks method except in reverse
- moved the cache world creation to the create world method so that the plugin does not lag on island creation - changed setting to GeneratorType enum - added vanilla generation option (takes advantage of null chunk generator) - deletes and regenerates cache world on bad seed comparison so that the cache world matches even on generator change
- moved the check for if the generator is a terrain generator to the methods that call regenerateTerrain
Co-authored-by: Daniel Scherf <[email protected]>
* Added flatlands generator - also added some logging about the generator type to ensure that server admins know what the correct enum values are * forgot to import arrays, silly me
Co-authored-by: Daniel Scherf <[email protected]>
- API changes: addedBlockPopulator() and addChunkGenerator() - configuration changes: generatorType is now type String, completely redid generators.yml to include several new config options and multiple biome types for generators - added custom block populators (that don't currently work for some reason but don't worry about it too much) - updated generators to extend abstract class IridiumChunkGenerator - added skyblockBiomeProvider to select and add biomes to generators
fixed wrong name for flat generation in the biome provider
WHERE IS MY KELP MOJANG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
guys i promise its not as bad as it looks