Implement IIFE and named functions to accomplish the style guide #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto feat-style-guides
giorgiofellipe
changed the title
Now the `www` contents will be compiled by gulp from `src`
|
@giorgiofellipe I'll push some commits to your branch while reviewing this pull request. |
Based on https://github.com/johnpapa/generator-hottowel/blob/8f70b149f21f89bd02fc 2199541e484945e233c0/app/templates/jshintrc
|
I forget to mention, I removed |
This reverts commit c2cbb9a.
Checkout `gulp-plumber` for more information
|
This workflow is going pretty well, I'll merge it because it's too big to stay working here. |
felquis
added a commit
that referenced
this pull request
Jul 3, 2015
Implement IIFE and named functions to accomplish the style guide
|
I'll keep the issues open, cause we should close them with tests like JSCS, JSHint, if we can't ensure a style guide, we shouldn't close the corresponding style guide issue. Thanks @giorgiofellipe sorry for that revert. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR starts to implement the style guides mentioned on #23 #24 and a bit of #28 (#28 (comment)).
There should be some mistakes, so would be great if you take a depth look and help fix them.