Basic pool & healthcheck query to handle broken connections #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basic connection pool & healthcheck usage to avoid failing on broken connections. Rollback was moved to query function to make it easier to manage the connection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As already mentioned e.g. in #12, Fody isn't capable to handle closed DB connections. They may happen due to DB restart, network issues etc.
This change introduces a basic usage of connection pool in the Events API code. In addition, because pool ensures recreating connections, but the broken state isn't known until execution of any query, the code executes a simple health check to trigger the pool to act. It prevents serving broken connection on first try after the break.
To simplify handling the connection, the rollback was moved to the
queryfunction.This PR is intended as a hotfix for issue we are observing regularly when using Events API, so other places or possible improvements were intentionally left unchanged.