Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/510-file-is-wrongly-reported-as-not-matching #537

Merged
merged 4 commits into from
Mar 22, 2024
Merged

fix/510-file-is-wrongly-reported-as-not-matching #537

merged 4 commits into from
Mar 22, 2024

Conversation

Sworzen1
Copy link
Contributor

@Sworzen1 Sworzen1 commented Mar 22, 2024 •
edited
Loading

List of changes

Fix file doesnt match do existed hash

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@Sworzen1 Sworzen1 force-pushed the fix/510-file-is-wrongly-reported-as-not-matching branch from 572a1d4 to 3807f65 Compare March 22, 2024 09:22
@Sworzen1 Sworzen1 marked this pull request as ready for review March 22, 2024 09:22
@Sworzen1 Sworzen1 linked an issue Mar 22, 2024 that may be closed by this pull request
GA submitter - happens that during submitting GA with the same metadata and using the same jsonld - file is wrongly reported as not matching #510
Closed
MSzalowski
MSzalowski approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@MSzalowski MSzalowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💪

govtool/frontend/src/hooks/forms/useCreateGovernanceActionForm.ts Outdated Show resolved Hide resolved
@Sworzen1 Sworzen1 merged commit 6849ef1 into develop Mar 22, 2024
3 of 4 checks passed
@Sworzen1 Sworzen1 deleted the fix/510-file-is-wrongly-reported-as-not-matching branch March 22, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSzalowski MSzalowski MSzalowski approved these changes

@JanJaroszczak JanJaroszczak Awaiting requested review from JanJaroszczak

@kickloop kickloop Awaiting requested review from kickloop

Assignees
No one assigned
Labels
🖥 Frontend Frontend related
Projects
None yet
Milestone
No milestone
2 participants
@Sworzen1 @MSzalowski