Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: passing random sorting to governance actions request #2619

Merged
merged 1 commit into from
Jan 10, 2025
Merged

fix: passing random sorting to governance actions request #2619

merged 1 commit into from
Jan 10, 2025

Conversation

MSzalowski
Copy link
Contributor

List of changes

  • When wallet is disconnected Random was passed when last path was drep directory

Checklist

  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@github-actions GitHub Actions
Copy link

❌ Docker Image Scan (Dockle) failed

No output

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

1 similar comment
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@MSzalowski MSzalowski requested a review from placek January 10, 2025 12:21
@MSzalowski MSzalowski force-pushed the fix/passing-random-sorting-to-gov-actions-on-disconnected-wallet branch from a6f8fa4 to b916ee6 Compare January 10, 2025 13:12
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

2 similar comments
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@MSzalowski MSzalowski merged commit 8e2d9ea into develop Jan 10, 2025
15 of 18 checks passed
@MSzalowski MSzalowski deleted the fix/passing-random-sorting-to-gov-actions-on-disconnected-wallet branch January 10, 2025 13:17
@github-actions GitHub Actions
Copy link

@MSzalowski
This PR is in the tag: develop-8e2d9ea18cd7ce1efb32a8381cebd0ca3fdfabfe , for govtool-metadata-validation service

@github-actions GitHub Actions
Copy link

@MSzalowski
This PR is in the tag: develop-8e2d9ea18cd7ce1efb32a8381cebd0ca3fdfabfe , for govtool-frontend service

@github-actions GitHub Actions
Copy link

@MSzalowski
This PR is in the tag: develop-8e2d9ea18cd7ce1efb32a8381cebd0ca3fdfabfe , for govtool-backend service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@placek placek placek approved these changes

@jdyczka jdyczka Awaiting requested review from jdyczka jdyczka is a code owner

@Ryun1 Ryun1 Awaiting requested review from Ryun1 Ryun1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MSzalowski @placek