Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#2609): fix wrong SPO vote totals #2616

Merged
merged 1 commit into from
Jan 9, 2025
Merged

fix(#2609): fix wrong SPO vote totals #2616

merged 1 commit into from
Jan 9, 2025
+209 −192

Conversation

MSzalowski
Copy link
Contributor

List of changes

  • Fix wrong SPO vote totals
  • Add total stake controlled by SPOs to network metrics
  • Fix wrong DRep total stake by filtering the epoch
  • Fix DRep and CC votes percentage on votes submitted section

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@MSzalowski MSzalowski linked an issue Jan 9, 2025 that may be closed by this pull request
🐛 SPO vote total on mainnet is incorrect #2609
Closed
@MSzalowski MSzalowski requested a review from placek January 9, 2025 08:47
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

✅ All checks succeeded

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

✅ All checks succeeded

@MSzalowski MSzalowski merged commit a5b5dd9 into develop Jan 9, 2025
10 of 12 checks passed
@MSzalowski MSzalowski deleted the fix/2609-spo-vote-total-on-mainnet-is-incorrect branch January 9, 2025 08:59
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

@MSzalowski
This PR is in the tag: develop-a5b5dd9c77b58d86f7f10080b024dd50bb40ff15 , for govtool-frontend service

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

@MSzalowski
This PR is in the tag: develop-a5b5dd9c77b58d86f7f10080b024dd50bb40ff15 , for govtool-metadata-validation service

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

@MSzalowski
This PR is in the tag: develop-a5b5dd9c77b58d86f7f10080b024dd50bb40ff15 , for govtool-backend service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@placek placek placek approved these changes

@jdyczka jdyczka Awaiting requested review from jdyczka jdyczka is a code owner

@Ryun1 Ryun1 Awaiting requested review from Ryun1 Ryun1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 SPO vote total on mainnet is incorrect
2 participants
@MSzalowski @placek