Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GovTool-v1.0.13-staging #1781

Merged
merged 48 commits into from
Aug 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
22b2083
fix: typo replace proposal to drepInfo
mesudip Jul 4, 2024
501ebe9
fix-test: accept integers when expected type is float
mesudip Aug 1, 2024
f2edf45
Fix: Add VITE_METADATA_API_URL env variable on test deployment
mesudip Aug 2, 2024
741de2d
Fix: Typo rename GTM_ID to VITE_GTM_ID
mesudip Aug 2, 2024
8338ba7
Fix formatting
mesudip Aug 2, 2024
6b4f0a1
chore: update dRep filter logic, use test ID instead of getByText
kneerose Aug 8, 2024
2e007f6
chore: add await on dRep sort assertion
kneerose Aug 8, 2024
75fd00e
fix: 3M_2 reject invalid data in edit form
kneerose Aug 8, 2024
90defa8
Merge pull request #1666 from IntersectMBO/infra/test-chores
mesudip Aug 8, 2024
70511f7
Merge pull request #1653 from IntersectMBO/fix/backend-test
mesudip Aug 8, 2024
c92ab66
Merge pull request #1700 from IntersectMBO/bugfix/dRep-sort-filter
kneerose Aug 8, 2024
7492ac3
Merge pull request #1471 from IntersectMBO/fix/typo/backend-test
mesudip Aug 8, 2024
672d9d8
[#1675] add type for validated metadata
j-dyczka Aug 6, 2024
71afc12
[#1675] updated Proposal and DRep types to match data received from BE
j-dyczka Aug 6, 2024
11db089
Merge pull request #1685 from IntersectMBO/fix/1675-blank-edit-drep-w…
jdyczka Aug 8, 2024
901caa3
change: to use new type of stake registration certificate
Ryun1 Aug 6, 2024
960e7c0
docs: updated changelog
Ryun1 Aug 7, 2024
7ce2184
docs: improve feature idea template and workflow
Ryun1 Aug 9, 2024
f7a2459
docs: refactor bug template and add workflow
Ryun1 Aug 12, 2024
1e27263
docs: updated changelog
Ryun1 Aug 12, 2024
be9b19f
docs: tweak base readme
Ryun1 Aug 12, 2024
f119d93
docs: update changelog
Ryun1 Aug 12, 2024
4d58ab3
feat(#1703): make voting on governance actions dependent on protocol …
MSzalowski Aug 9, 2024
ec95867
fix(#1703): fix storybook tests
MSzalowski Aug 9, 2024
3974d6e
Merge pull request #1716 from IntersectMBO/feat/1703-bootstrap-only-a…
MSzalowski Aug 13, 2024
0d6ea55
[#1183] Refactor routes for registration and retirement
j-dyczka Aug 9, 2024
f7c73df
[#1183] Add checks for registration and retirement routes
j-dyczka Aug 9, 2024
a6d516b
[#1183] Remove unused components
j-dyczka Aug 9, 2024
e687650
Merge pull request #1714 from IntersectMBO/fix/1183-restrict-acces-fo…
jdyczka Aug 13, 2024
3158146
[#1050] Add missing data-testid attributes
j-dyczka Aug 8, 2024
3495035
chore: remove .envrc.example and .pre-commit-config
MSzalowski Aug 13, 2024
1f960df
docs: tweak and improve issue templates
Ryun1 Aug 12, 2024
f8c6660
docs: fix projects for issue templates
Ryun1 Aug 12, 2024
485023a
Merge pull request #1730 from IntersectMBO/chore/tidy-base-repo
MSzalowski Aug 14, 2024
bd283d6
Merge pull request #1706 from IntersectMBO/fix/1050-missing-test-ids
MSzalowski Aug 14, 2024
e47e3a9
fix: fix parsing metadata validation
MSzalowski Aug 17, 2024
2b18235
Merge pull request #1755 from IntersectMBO/fix/fix-metadata-parsing
MSzalowski Aug 17, 2024
33e6b87
Merge pull request #1757 from IntersectMBO/develop
MSzalowski Aug 20, 2024
04548cb
add new dockerfile
mpavlovicbb Aug 21, 2024
8a9dd9f
add new dockerfile
mpavlovicbb Aug 21, 2024
cdd9dac
Merge pull request #1773 from IntersectMBO/dockerfile-dev
MSzalowski Aug 21, 2024
fe30834
Merge pull request #1776 from IntersectMBO/dockerfile-test
mpavlovicbb Aug 21, 2024
6063a71
Merge pull request #1779 from IntersectMBO/develop
MSzalowski Aug 21, 2024
0cee1f3
feat(#1793): change domain on all guides links
MSzalowski Aug 22, 2024
5186ba5
Merge pull request #1794 from IntersectMBO/feat/1793-change-domain-on…
MSzalowski Aug 22, 2024
30d0e27
core: bump GovTool to v1.0.13
MSzalowski Aug 22, 2024
4112253
Merge pull request #1795 from IntersectMBO/chore/bump-govtool-to-v1.0.13
MSzalowski Aug 22, 2024
ca41404
Merge pull request #1796 from IntersectMBO/develop
MSzalowski Aug 22, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 0 additions & 54 deletions .envrc.example

This file was deleted.

25 changes: 0 additions & 25 deletions .github/ISSUE_TEMPLATE/bug_report.md

This file was deleted.

96 changes: 96 additions & 0 deletions .github/ISSUE_TEMPLATE/bug_report.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,96 @@
name: 🐛 Bug report
description: You found a bug!
title: '🐛 '
labels: ["🐛 Bug"]
projects: ["IntersectMBO/30", "IntersectMBO/34"]
body:
- type: markdown
attributes:
value: |
## 🌟 **Thank you for contributing to GovTool!**
- type: markdown
attributes:
value: |
Before submitting a new issue please check the [existing issues](https://github.com/IntersectMBO/govtool/issues) to avoid duplication.

- type: dropdown
id: area
attributes:
label: Area
description: What part of GovTool does this feature affect?
options:
- Proposal Pillar
- Voting Pillar
- Delegation Pillar
- Wrapper
- Other
- Not sure
validations:
required: true

- type: dropdown
id: domain
attributes:
label: Domain
description: Which GovTool instance were you connected to?
options:
- sanchogov.tools
- dev-sanchogov.tools
- test-sanchogov.tools
- stage-sanchogov.tools
- preview.gov.tools
- Custom setup
validations:
required: true

- type: input
id: wallet
attributes:
label: Which wallet were you using?
description: Please provide which wallet and version you were using
placeholder: |
Eternl wallet v1.12.6.6
validations:
required: false

- type: textarea
id: context
attributes:
label: Context
description: Please give the context to what you were trying to achieve
placeholder: |
I was trying to register as a DRep and the following happened...
validations:
required: true

- type: textarea
id: reproduce
attributes:
label: Steps to reproduce
description: Explain the steps to reproduce
placeholder: |
1. Connect wallet
2. Navigate to the dashboard
3. Click on "Register as DRep"
validations:
required: true

- type: textarea
id: actual-behavior
attributes:
label: Actual behavior
description: A description of the erroneous outcome
placeholder: |
A error came up on the screen stating...
validations:
required: true

- type: textarea
id: expected-behavior
attributes:
label: Expected behavior
description: A description of what you expect to happen instead
placeholder: |
The DRep registration transaction was sent and I was registered
validations:
required: true
78 changes: 61 additions & 17 deletions .github/ISSUE_TEMPLATE/feature_idea.yml
Original file line number Diff line number Diff line change
@@ -1,44 +1,88 @@
name: Feature idea
name: 💡 Feature idea
description: Idea or request for some feature on the GovTool roadmap
labels: [':thought_balloon: idea']
title: "💡 "
labels: ["💡 Feature idea"]
projects: ["IntersectMBO/30", "IntersectMBO/34"]
body:
- type: markdown
attributes:
value:
value: |
**Thank you for contributing to our project!** :green_heart:
## 🌟 **Thank you for contributing to GovTool!**
- type: markdown
attributes:
value: |
Before submitting a new issue consider [starting a new discussion](https://github.com/IntersectMBO/govtool/discussions/new?category=ideas).

Instead of opening this issue, consider [starting a new idea discussion](https://github.com/IntersectMBO/govtool/discussions/new?category=ideas).
That way, we can discuss & refine your idea together, before we adopt it as a feature into the roadmap.
- type: dropdown
id: area
attributes:
label: Area
description: What part of GovTool does this feature affect?
options:
- Proposal Pillar
- Voting Pillar
- Delegation Pillar
- Wrapper
- Other
- Not sure
validations:
required: true

- type: textarea
id: why
- type: dropdown
id: design-needed
attributes:
label: Why
description: Why do we need or want this feature
placeholder: |
Give context and describe the problem, challenge or opportunity you see
label: Is there new design needed?
description: Will this feature require new or edit to existing frontend designs?
options:
- 'Yes'
- 'No'
- Not sure
validations:
required: true

- type: textarea
id: what
attributes:
label: What
description: What is this feature roughly about
label: What?
description: What is this feature?
placeholder: |
For example describe a new API endpoint, a change in messaging formats,
For example describe a new API endpoint, a change in wording,
a new configuration option, ...
validations:
required: true

- type: textarea
id: why
attributes:
label: Why?
description: Why do we need or want this feature?
placeholder: |
Give context and describe the problem the idea solves
validations:
required: true

- type: textarea
id: how
attributes:
label: How
description: How could we realize this feature
label: How?
description: How can we realize this feature?
placeholder: |
Which technical solutions, libraries or systems should be used, which
components need to change, steps how to implement this, ...
validations:
required: true

- type: markdown
attributes:
value: |
---

- type: textarea
id: user-story
attributes:
label: (Optional) User Story with acceptance criteria
description: See GovTool examples [here](https://github.com/IntersectMBO/cardano-test-plans/blob/main/userStoryInventoryChangHF.md#2g-delegate-to-self-for-registered-dreps).
placeholder: |
As a [ada holder | DRep | Direct voter], I want [some goal] so that [some reason].
validations:
required: false
Binary file added .github/images/voltaire-govtool-header.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
54 changes: 54 additions & 0 deletions .github/workflows/label-bug-report.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
name: Add labels to 🐛 Bug report issues

on:
issues:
types: [opened, edited]

permissions:
issues: write
contents: read

jobs:
apply-labels:
runs-on: ubuntu-latest
steps:
- name: Check if issue is a "🐛 Bug report"
id: check_is_bug_report
run: |
echo "## Checking if issue is a 'Feature idea'..."
if [[ "${{ github.event.issue.title }}" == "🐛 "* ]]; then
echo "is_bug_report=true" >> $GITHUB_ENV
else
echo "is_bug_report=false" >> $GITHUB_ENV
fi

- name: Apply label based on feature area
if: ${{ env.is_bug_report == 'true' }}
uses: actions/github-script@v6
with:
script: |
const areaMap = {
"Proposal Pillar": "📜 Proposal Pillar",
"Voting Pillar": "🗳️ Voting Pillar",
"Delegation Pillar": "♟️ Delegation Pillar",
"Wrapper": "🎁 Wrapper",
"Other": "Other area",
"Not sure": "❓Unknown area",
};

const issueBody = context.payload.issue.body;

// Match the Area selected under the "### Area" header
const areaMatch = issueBody.match(/### Area\s*\n\s*(.*)\s*\n/);
const area = areaMatch ? areaMatch[1].trim() : null;

const labelToAdd = areaMap[area];

if (labelToAdd) {
await github.rest.issues.addLabels({
issue_number: context.issue.number,
owner: context.repo.owner,
repo: context.repo.repo,
labels: [labelToAdd],
});
}
Loading
Loading