Merge pull request #2617 from IntersectMBO/fix/fix-opening-relative-p…

…aths-in-external-links

fix: opening relative paths in external links

CHANGELOG.md

@@ -17,6 +17,7 @@ changes.
 ### Fixed
 
 - Fix counting submitted votes [Issue 2609](https://github.com/IntersectMBO/govtool/issues/2609)
+- Fix opening relative paths in external links
 
 ### Changed
 

govtool/frontend/src/components/organisms/Modal/ExternalLinkModal.tsx

@@ -70,7 +70,9 @@ export const ExternalLinkModal = forwardRef<HTMLDivElement>((_, ref) => {
         <Button
           data-testid="continue-modal-button"
           onClick={() => {
-            openInNewTab(state?.externalLink || "#");
+            if (state?.externalLink) {
+              openInNewTab(state?.externalLink);
+            }
             closeModal();
           }}
           sx={{

govtool/frontend/src/utils/openInNewTab.ts

@@ -1,4 +1,10 @@
 export const openInNewTab = (url: string) => {
-  const newWindow = window.open(url, "_blank", "noopener,noreferrer");
+  // Ensure the URL is absolute
+  const fullUrl =
+    url.startsWith("http://") || url.startsWith("https://")
+      ? url
+      : `https://${url}`;
+
+  const newWindow = window.open(fullUrl, "_blank", "noopener,noreferrer");
   if (newWindow) newWindow.opener = null;
 };