-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for MS-DOS #358
base: master
Are you sure you want to change the base?
Conversation
One thing that stopped me from doing this before was that I wasn’t sure if some of the code for handling drives in oaths might be useful for Windows ... thoughts? |
Yeah, you have a point there. I wish we could dispense with drive letters, though. Some of the ugliest code is in there. |
I'll take a shot at revising this to not strip out the file system related code. |
For my display work, I'm using Sokol (https://github.com/floooh/sokol). Specifically, I am using This lets us run the same code on Unix, macOS, Windows, Web, and more. I don't worry a lot about the existing code for handling keyboard and mouse input. :) |
My thoughts have involved a URL-based file system, and handling drive letters the way whatwg/url does. |
Cool. Using the sokol_app "event-based keyboard, mouse and touch input" I guess. It looks as though it will have issues of similar complexity to the way the X input events needed to be handled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line 61 of (new) src/ether.c has #endif /* DOS */
but the ifdef remover removed the wrong one: #endif /* MAIKO_ENABLE_INTERNET */
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this might gate some other work
@masinter -- I'll fix the endif problem. I'm probably going to revise this substantially because Bruce asked that the file-system code handling drive letters be left for when/if he has a native Windows port. It also has conflicting commits with the current master so I'll be needing to rebase and cleanup before merging. |
... and remove references to them from CMakeList.txt and makefile-tail
…ns, update endif comments
... and remove references to them from CMakeList.txt and makefile-tail
…ns, update endif comments
This is the first cut at removing support for MS-DOS as I don't think we're ever going to build there again