Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numba-mlir integration #1194

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Conversation

Hardcode84
Copy link
Contributor

This is an alternative to #1130

Instead of using target options, use an alternative pipeline class.
Options code is still there so we can switch after they fixed.

@Hardcode84 Hardcode84 marked this pull request as ready for review November 2, 2023 18:23
@Hardcode84 Hardcode84 requested a review from diptorupd as a code owner November 2, 2023 18:24
@ZzEeKkAa ZzEeKkAa marked this pull request as draft November 2, 2023 21:24
@ZzEeKkAa
Copy link
Contributor

ZzEeKkAa commented Nov 2, 2023

I've converted PR to draft, since it is WIP. @Hardcode84 are you going to update CI in this PR?
Some highlights from our call:

  • Add NUMBA_DPEX_DEFAULT_JIT_COMPILER that can be mlir
  • Update testing matrix to run tests with and without mlir

@diptorupd
Copy link
Contributor

Overall the changes look good and are compartmentalized we should merge once we have a proper plan for CI.

@Hardcode84 Hardcode84 marked this pull request as ready for review November 7, 2023 18:16
Copy link
Contributor

@ZzEeKkAa ZzEeKkAa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@ZzEeKkAa ZzEeKkAa merged commit 7315aef into IntelPython:main Nov 14, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants