Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lifetime management for sycl event #1188

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Conversation

ZzEeKkAa
Copy link
Contributor

@ZzEeKkAa ZzEeKkAa commented Oct 24, 2023

Memory lifetime wasn't set properly which resulted in core dumps of running kernels if boxed sycl event argument where destroyed by GC. New implementation wraps parent into MemInfo object and lifetime of the object is managed by it which is properly managed by numba's compiler.

P.S. : also fixed functions signature for dpctl sycl binding.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@ZzEeKkAa ZzEeKkAa self-assigned this Oct 24, 2023
@ZzEeKkAa ZzEeKkAa force-pushed the fix/sycl_event_meminfo branch 3 times, most recently from 8440510 to b8d8b76 Compare October 24, 2023 16:49
@ZzEeKkAa ZzEeKkAa marked this pull request as ready for review October 24, 2023 16:49
@ZzEeKkAa ZzEeKkAa requested a review from diptorupd as a code owner October 24, 2023 16:49
@ZzEeKkAa ZzEeKkAa enabled auto-merge October 24, 2023 16:50
@ZzEeKkAa ZzEeKkAa force-pushed the fix/sycl_event_meminfo branch from b8d8b76 to d4d1ff0 Compare October 24, 2023 18:15
Copy link
Contributor

@diptorupd diptorupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for these important changes.

@ZzEeKkAa ZzEeKkAa merged commit af314f5 into main Oct 25, 2023
23 checks passed
@ZzEeKkAa ZzEeKkAa deleted the fix/sycl_event_meminfo branch October 25, 2023 11:31
github-actions bot added a commit that referenced this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants