Miscellaneous changes to compiler internals #1173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 12, 2023 18:03
- Changes to the class constructor to make it easier to use from
places other than the parfor_lowerer. Removed the need to pass
a lowerer object and instead pass a context and builder.
- Adds a new helper function populate_kernel_args_and_args_ty_arrays
that populates arrays storing kernel args and kernel arg types.
- We should not generate a cpython or a cfunc wrapper for a
kernel decorated function.
- The no_compile is also set to True as the kernel LLVM IR
will not be compiled to an executable object code by Numba.
Instead, numba-dpex will compile the LLVM IR to SPIR-V and
generate a sycl::kernel_bundle.
github-actions bot
added a commit
that referenced
this pull request
Oct 13, 2023
Miscellaneous changes to compiler internals aaafcfa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have you provided a meaningful PR description?
Changes to the kernel_launcher.KernelLaunchIRBuilder class constructor to make it easier to use from
places other than the parfor_lowerer. Removed the need to pass a lowerer object and instead pass a context and builder.
Adds a new helper function populate_kernel_args_and_args_ty_arrays that populates arrays storing kernel args and kernel
arg types.
We should not generate a cpython or a cfunc wrapper for a kernel decorated function.
The no_compile is also set to True as the kernel LLVM IR will not be compiled to an executable object code by Numba.
Instead, numba-dpex will compile the LLVM IR to SPIR-V and generate a sycl::kernel_bundle.
Have you added a test, reproducer or referred to an issue with a reproducer?
Have you tested your changes locally for CPU and GPU devices?
Have you made sure that new changes do not introduce compiler warnings?
If this PR is a work in progress, are you filing the PR as a draft?