Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanups to kernel target #1168

Merged
merged 3 commits into from
Oct 12, 2023
Merged

Cleanups to kernel target #1168

merged 3 commits into from
Oct 12, 2023

Conversation

diptorupd
Copy link
Contributor

  • Have you provided a meaningful PR description?

Adds initial set of changes to make enable creating a new Dispatcher sub-type in numba-dpex to compile kernel decorated functions. The changes in this PR are mostly lightweight refactoring.

  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

Diptorup Deb added 3 commits October 12, 2023 12:34
    - Renames functions to better indicate usage. (e.g., s/ocl/spir/g)
    - Renamed DPEX_KERNEL_TARGET_NAME to "dpex_kernel" from "SyclDevice".
    - Removes unused globals: VALID_CHARS, LINK_ATOMIC.
    - Removes unused imports.
    - Minor typo clean up and removes superfluous comments.
@diptorupd diptorupd force-pushed the cleanups_to_kernel_target branch from 5d90597 to 262ed52 Compare October 12, 2023 17:53
@diptorupd diptorupd merged commit 86e1be7 into main Oct 12, 2023
22 checks passed
@diptorupd diptorupd deleted the cleanups_to_kernel_target branch October 12, 2023 19:02
github-actions bot added a commit that referenced this pull request Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant