Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve box unbox tests #1153

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Improve box unbox tests #1153

merged 1 commit into from
Oct 17, 2023

Conversation

ZzEeKkAa
Copy link
Contributor

@ZzEeKkAa ZzEeKkAa commented Oct 2, 2023 •
edited
Loading

Updates typing tests to have unified set of tests to run on dpex provided types. Makes sure that ref count is expected. This changes reviled some bugs in reference count manipulations, that were fixed.

  • queue inc/ref was not properly matched. Current change fixes it but may result in SyclQueue being garbage collected during run. It is not big deal for now, since all queues being passed through cache that prevents it from being garbage collected.

Checks

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@ZzEeKkAa ZzEeKkAa self-assigned this Oct 2, 2023
@ZzEeKkAa ZzEeKkAa force-pushed the fix/improve_unbox_box_tests branch 4 times, most recently from 16344dc to ca62909 Compare October 3, 2023 20:09
@ZzEeKkAa ZzEeKkAa force-pushed the fix/improve_unbox_box_tests branch from ca62909 to 300123d Compare October 16, 2023 21:55
@ZzEeKkAa ZzEeKkAa force-pushed the fix/improve_unbox_box_tests branch from 300123d to b3b7522 Compare October 16, 2023 22:54
@ZzEeKkAa ZzEeKkAa marked this pull request as ready for review October 16, 2023 22:58
diptorupd
diptorupd reviewed Oct 17, 2023
View reviewed changes
numba_dpex/tests/core/types/test_box_unbox.py
return a


# @numba.njit
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove commented out code. Also dpjit is for now equivalent to njit(Parallel=True)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ops, did not see the comment. Let me address this issue in separate PR.

@ZzEeKkAa ZzEeKkAa merged commit 26518c3 into main Oct 17, 2023
23 checks passed
@ZzEeKkAa ZzEeKkAa deleted the fix/improve_unbox_box_tests branch October 17, 2023 15:31
github-actions bot added a commit that referenced this pull request Oct 17, 2023
@github-actions
Merge pull request #1153 from IntelPython/fix/improve_unbox_box_tests 2…
82a04b5 
…6518c3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diptorupd diptorupd diptorupd approved these changes

@chudur-budur chudur-budur Awaiting requested review from chudur-budur

Assignees

@ZzEeKkAa ZzEeKkAa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZzEeKkAa @diptorupd