Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the layout of tables to markdown syntax #324

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kolibril13
Copy link
Contributor

More intuitive, and will give better result when rendering with nbsphinx.

Copy link
Member

@zivy zivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason this change isn't compatible with the testing code (fails on this line). Not sure if this is worth looking into as both html and md are fine. 99% of the people using the notebooks will never be aware which is being used in the text cells.

@kolibril13
Copy link
Contributor Author

Maybe we can then remove that test?
Becuase nbsphinx will render these markdown flavoured tables nicely: https://nbsphinx.readthedocs.io/en/0.8.6/markdown-cells.html#Tables
https://raw.githubusercontent.com/spatialaudio/nbsphinx/0.8.6/doc/markdown-cells.ipynb
image

@zivy
Copy link
Member

zivy commented Oct 28, 2021

I'd rather not remove that test, as it is ensuring that there are no broken urls in the text cells. I can invest a bit of time looking into this, but that will be during the weekend. Worst case, if there is no solution I can disable the test for this notebook, similar to what we did here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants