Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dicom sort rebase #1197

Draft
wants to merge 19 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
f3459a1
feat(image-sets-normalization): add new pipeline
thewtex Nov 16, 2023
dff675b
fix(image-sets-normalization): update codegened files for new pipeline
PaulHax Mar 13, 2024
6040800
feat(image-sets-normalization): Sort DICOMs
PaulHax Mar 18, 2024
7a58e94
feat(image-sets-normalization): read DICOM tags
PaulHax Mar 19, 2024
6b793a2
fix(gdcmDiscriminateVolume): Remove prints
PaulHax Mar 22, 2024
231608e
chore(test_image_sets_normalization): fix one series test
PaulHax Mar 22, 2024
d778fbc
refactor(image-sets-normalization): rename output to image-sets
PaulHax Mar 26, 2024
cdc81c5
refactor(image-sets-normalization): revamp data structures
PaulHax Mar 26, 2024
a82e967
fix(image-sets-normalization): fix sorting of files in series
PaulHax Mar 28, 2024
81e55b5
feat(image-sets-normalization): make tag keys english
PaulHax Mar 29, 2024
37f9ec1
fix(image-sets-normalization): check more tags when grouping volumes
PaulHax Mar 31, 2024
884bea6
feat(image-sets-normalization): array and number types for tag values
PaulHax Apr 1, 2024
0e68145
chore(dicom): add mr test for image sets normalization
PaulHax Apr 3, 2024
e2ec910
WIP feat(image-sets-normalization): convert to UTF8 from character set
PaulHax Apr 3, 2024
933cbbc
WIP fix(image-sets-normalization): remove trailing space on tag values
PaulHax Apr 4, 2024
9890d80
WIP fix(image-sets-normalization): fallback to tag hex key if private…
PaulHax Apr 4, 2024
e3eb7da
WIP feat(image-sets-normalization): add group by options
PaulHax Apr 4, 2024
75f1c7a
chore(dicom): update wasm and demo-app index.html
thewtex Aug 13, 2024
767714d
build: remove extra enable_testing
thewtex Aug 28, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/compare-images/typescript/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,4 +62,4 @@
"type": "git",
"url": "https://github.com/InsightSoftwareConsortium/ITK-Wasm"
}
}
}
9 changes: 9 additions & 0 deletions packages/dicom/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,12 @@ enable_testing()

add_subdirectory(gdcm)
add_subdirectory(dcmtk)

add_test(NAME image-sets-normalization-help COMMAND image-sets-normalization --help)

add_test(NAME image-sets-normalization-smoke
COMMAND image-sets-normalization image-sets.json --files
${CMAKE_CURRENT_SOURCE_DIR}/test/data/input/DicomImageOrientationTest/ImageOrientation.1.dcm
${CMAKE_CURRENT_SOURCE_DIR}/test/data/input/DicomImageOrientationTest/ImageOrientation.2.dcm
${CMAKE_CURRENT_SOURCE_DIR}/test/data/input/DicomImageOrientationTest/ImageOrientation.3.dcm
)
3 changes: 3 additions & 0 deletions packages/dicom/gdcm/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ include(${ITK_USE_FILE})
add_executable(read-image-dicom-file-series read-image-dicom-file-series.cxx)
target_link_libraries(read-image-dicom-file-series PUBLIC ${ITK_LIBRARIES})

add_executable(image-sets-normalization image-sets-normalization.cxx)
target_link_libraries(image-sets-normalization PUBLIC ${ITK_LIBRARIES})

if (WASI)
return()
endif()
Expand Down
Loading
Loading