feat: fine row deletion #1193
Open
feat: fine row deletion #1193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chloe-renaud
requested changes
Dec 13, 2024
src/use-lunatic/commons/variables/behaviours/resizing-behaviour.ts
Outdated
Show resolved
Hide resolved
chloe-renaud
approved these changes
Dec 16, 2024
|
MailineN
approved these changes
Dec 18, 2024
Grafikart
approved these changes
Jan 5, 2025
| } | ||
| // Case 0: trying to delete with wrong index | ||
| if (indexToRemove >= nbRows || indexToRemove < 0) { | ||
| return; |
There was a problem hiding this comment.
Ici j'aurais tendance à throw une exception car c'est un cas qui n'est vraiment censé jamais arrivé
| if (nbRows <= 0) { | ||
| return null; | ||
| } | ||
|
|
||
| const canControlRows = min !== max && Number.isFinite(max); |
There was a problem hiding this comment.
il faut aussi que nbRows > min non ?
| ))} | ||
| <br /> |
| if (0 > removedIndex || array.length <= removedIndex) { | ||
| return array; | ||
| } | ||
| return [...array].filter((_, i) => i !== removedIndex); |
There was a problem hiding this comment.
La destructuration ne sert pas ici, filter va déjà recréer un nouveau tableau
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New feature ⭐
Allow fine row deletion in dynamic-table or loop