Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc fixes for packaging ease #225

Closed
wants to merge 5 commits into from
Closed

Misc fixes for packaging ease #225

wants to merge 5 commits into from

Conversation

Noodlez1232
Copy link

This should close #221. This has some changes to packaging to make packaging easier for distributions.
The changes are as follows:

  • Package version is pulled straight from package.json
  • The path to ffmpeg can be changed in the arguments to the program
  • The db path can now be changed in arguments
  • package.json now includes postject for ease of packaging
  • some of the arugments/settings parsing has been fixed to not polute all the structs with useless environment variables and arguments.

@Noodlez1232
Get package version straight from package.json
cd53feb
@Noodlez1232
Fix argument/settings parsing
f67d4a3 
Before, both structs were being polluted with the environment variables.
The way it's done now, it is no longer poluted and (in my opinion) is a
bit cleaner as well.
@Noodlez1232
Remove hardcoded paths
20deec1 
All paths can now be set in the arguments, and are all derived from the
workPath (by default: ./db). This *should* require no change from the
outside users as well, a transparent change.
@Noodlez1232
Fix up package.json and pnpm-lock.yaml
5c43d4e 
Including the sentinel was confusing postject. That's been moved to a
different file outside the package.json.

postject has also been added to the package.json, since it was being
used, but was not included in the lock. Mostly for completeness.
@Noodlez1232 Noodlez1232 marked this pull request as ready for review November 7, 2024 18:43
@Noodlez1232
Copy link
Author

I'd like to start discussion for the separation of settings.json as well.
Since settings.json includes information that could potentially be moved somewhere else (e.g. /etc), it may make sense to add an argument to move its path. The other states (attachments.json, cookies.json, etc.) can still be kept in ./db, since I agree this makes much more sense, but settings.json much like the path of ffmpeg can change based on the distro. (e.g. NixOS allowing setting of settings.json using its own language.)

@Noodlez1232
Removed all the separate pathing and only have FFMPEG path in args
13a8d95 
This moves everything back into the db directory, and only allows the
FFMPEG path to be changed. This also moves around some logic, and
removes unnecessary blobs out of the distribution.
@Inrixia Inrixia mentioned this pull request Nov 7, 2024
Merged
@Inrixia Inrixia closed this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some changes for ease of packaging
2 participants
@Noodlez1232 @Inrixia