Added support for output to Mqtt broker #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for output Mqtt broker
deece
requested changes
Mar 29, 2021
| def send(self, vals): | ||
| client = mqtt.Client() | ||
| client.username_pw_set(username=self.mqtt_user, password=self.mqtt_pass) | ||
| client.connect(self.mqtt_host, self.mqtt_port, self.mqtt_keepalive) |
There was a problem hiding this comment.
Hmm, I think we would be better off connecting on class instantiation and keeping the connection open, rather than connecting & disconnecting each time we have a new set of outputs.
We will need to handle the case where the client is disconnected and attempt a reconnect, and also if we get another send request while the client is already attempting to connect.
|
Is this still likely to be merged at some point? This would be a great addition IMO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.