feat: add rwa issuance #1357
Merged
feat: add rwa issuance #1357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
janndriessen
force-pushed
the
feat/add-rwa-issuance
branch
from
61f9547
to
15ba4d1
Compare
janndriessen
commented
Jun 17, 2024
| if (outputToken.symbol !== RealWorldAssetIndex.symbol) return units | ||
| return ( | ||
| (inputTokenAmount * BigInt('1000000000000000000')) / | ||
| BigInt('23800000000000000') |
There was a problem hiding this comment.
For issuances we need to take the exchange rate into account - as otherwise the output token amount would be wrong since RWA is not 1-1 wstETH like hyETH before.
0xonramp
reviewed
Jun 18, 2024
Comment on lines
+154
to
+155
| inputToken.symbol === RealWorldAssetIndex.symbol || | ||
| outputToken.symbol === RealWorldAssetIndex.symbol |
There was a problem hiding this comment.
Curious - why is it true here if it's not for hyETH? Or was hyETH here before but got removed?
There was a problem hiding this comment.
Because for presale the tokens use the issuance and once live they use flash minting. If hyETH would be still active here, the swap functionality would try to return an issuance quote. See this #1331 for decoupling these functionalities.
# Conflicts: # src/app/presales/constants.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Resources
Test Data or Screenshots
By submitting this pull request, you are confirming the following to be true:
IndexCoop/index-app.