chore: use chain aware address #1320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
0xonramp
commented
Jun 3, 2024
0xonramp
commented
Jun 3, 2024
| price_change_percentage_24h_in_currency: { usd: number } | ||
| } | ||
|
|
||
| export const fetchCoingeckoMarketData = async ( |
There was a problem hiding this comment.
Unused in the codebase.
janndriessen
reviewed
Jun 4, 2024
| @@ -26,6 +26,7 @@ export function ProductList() { | |||
| async function fetchProducts() { | |||
| const analyticsPromises = Promise.all( | |||
| productTokens.map((token) => | |||
| // TODO: https://github.com/IndexCoop/analytics-sdk/issues/30 | |||
There was a problem hiding this comment.
ah yea. I was thinking about this recently. 😅 will try to take a look at the task this week.
janndriessen
reviewed
Jun 4, 2024
| const path = `/quote?takerAddress=${address}&inputToken=${inputToken.address}&outputToken=${outputToken.address}&inputAmount=${inputAmount.toString()}&chainId=${chainId}` | ||
| const inputTokenAddress = getAddressForToken(inputToken, chainId) | ||
| const outputTokenAddress = getAddressForToken(outputToken, chainId) | ||
| const path = `/quote?takerAddress=${address}&inputToken=${inputTokenAddress}&outputToken=${outputTokenAddress}&inputAmount=${inputAmount.toString()}&chainId=${chainId}` |
There was a problem hiding this comment.
nice, making it future proof. 🌟
janndriessen
reviewed
Jun 4, 2024
src/lib/hooks/use-best-quote/utils/issuance/redemption-quote.ts
Outdated
Show resolved
Hide resolved
janndriessen
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
getAddressForTokento get chain-aware address where possible.