Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: separate quote hooks per feature #1331

Open
1 task
janndriessen opened this issue Jun 9, 2024 · 2 comments
Open
1 task

refactor: separate quote hooks per feature #1331

janndriessen opened this issue Jun 9, 2024 · 2 comments

Comments

@janndriessen
Copy link
Collaborator

janndriessen commented Jun 9, 2024

Check if we can find a way to separate the individual quote hooks more and then let features have there individual mechanisms for getting quotes. As the requirement for features like leverage suite or trade are very different it would be better to split this up (even if repeating some code). This way it's easier customizable to the individual needs.

Progress

Some of this has happened already e.g. legacy has its own quote functions.

TODOs

  • first separate custom logic of different features e.g. only swap or only leverage suite to their appropriate folders
@janndriessen
Copy link
Collaborator Author

Thoughts on this? @0xonramp

@janndriessen
Copy link
Collaborator Author

A lot of this might change with recent token deprecations. So let's wait on decisions here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant