build: add biome #109
Open
build: add biome #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janndriessen
commented
Jan 3, 2025
biome.json
Outdated
| "noForEach": "warn" | ||
| }, | ||
| "style": { | ||
| "noNonNullAssertion": "off", |
There was a problem hiding this comment.
This one can be turned to warn once it works better to disable lines or files in biome v2: biomejs/biome#4569.
Until then I'd recommend to keep lines like // eslint-disable-next-line @typescript-eslint/no-explicit-any in the project to be able to simple find/replace later on.
Let me know what you think? @0xonramp @tokdaniel
janndriessen
commented
Jan 3, 2025
biome.json
Outdated
| "noUselessElse": "off" | ||
| }, | ||
| "suspicious": { | ||
| "noExplicitAny": "off", |
There was a problem hiding this comment.
Same for this rule.
janndriessen
commented
Jan 3, 2025
| @@ -1,12 +1,45 @@ | |||
| { | |||
There was a problem hiding this comment.
Please check the config and let me know if you'd add/edit anything. @0xonramp @tokdaniel
It should be pretty similar to what we had. The only changes as you can see from the altered files is mostly imports and colon for every end of line e.g. props in an object.
tokdaniel
previously approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds biome to handle formatting and linting. Removes eslint and prettier.