Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @stefanpauliuk and @nheeren,
i checked out the repo after seeing the poster at GRC. It wasn't clear to me how to install the package and then I saw your discussion in #4. In this PR there is a setup.py file to make
odym
an installable package. You can test it in a new condaenv/virtualenv by installing it from my fork:Like this you have an easy way to directly install it from github, even before you put it on pypi/anaconda.
You'll probably want a different package namespace than what I added in
odym/__init__.py
, that's just a suggestion based on the syntax you use in the tutorial notebook. You could then also get rid of the "path hacking" in the notebooks ifodym
is installed.I also removed some of the compiled .pyc files and added them to gitignore, I think there's no reason to have these on github.
Let me know if this is useful for you. I can also give some inputs if you want to make it available via conda.