Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py and installable package #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

haasad
Copy link

@haasad haasad commented May 25, 2018

Hey @stefanpauliuk and @nheeren,

i checked out the repo after seeing the poster at GRC. It wasn't clear to me how to install the package and then I saw your discussion in #4. In this PR there is a setup.py file to make odym an installable package. You can test it in a new condaenv/virtualenv by installing it from my fork:

pip install git+https://github.com/haasad/ODYM

Like this you have an easy way to directly install it from github, even before you put it on pypi/anaconda.

You'll probably want a different package namespace than what I added in odym/__init__.py, that's just a suggestion based on the syntax you use in the tutorial notebook. You could then also get rid of the "path hacking" in the notebooks if odym is installed.

I also removed some of the compiled .pyc files and added them to gitignore, I think there's no reason to have these on github.

Let me know if this is useful for you. I can also give some inputs if you want to make it available via conda.

@nheeren
Copy link
Member

nheeren commented May 27, 2018

Thanks Adrian!! This package is still a bit of a moving target which is why we did not invest too much time in some of these things yet (such as conda).

pip install git+https://github.com/haasad/ODYM

Seems cool. Stefan should have a look at this as he is the main chef here.

You'll probably want a different package namespace than what I added in odym/init.py, that's just a suggestion based on the syntax you use in the tutorial notebook. You could then also get rid of the "path hacking" in the notebooks if odym is installed.

Sorry – I am not sure if I get it...

I also removed some of the compiled .pyc files and added them to gitignore, I think there's no reason to have these on github.

Yes! Thanks – I also meant to do that for a while now...

@ntropy-esa
Copy link

An easy install is still relevant in 2020 ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants