JIRA : USER-2015

[tintin2010]

• Adding Domain clause to GRILL/LENS grammar as an entry point to "User DSL"

  modified: ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g
  modified: ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g

[sumashivaprasad]

Pls add a UT for this like we discussed..Before that pls discuss with @Amareshwari if they are planning to migrate the grammar soon?

[sharadag]

User related DSL shouldn't be part of the Hive repo. Very soon we will get
away with the our forked Hive repo and will start depending on the external
Hive releases.

On Mon, Nov 3, 2014 at 11:05 AM, Suma S [email protected] wrote:

Pls add a UT for this like we discussed..Before that pls discuss with
@Amareshwari https://github.com/Amareshwari if they are planning to
migrate the grammar soon?

—
Reply to this email directly or view it on GitHub
#55 (comment).

[sumashivaprasad]

Hi Sharad,

This pull request is to add a

DOMAIN clause to the grammar similiar to CUBE clause and this doesnt
include any USER DSL specific changes.

For GRILL to differentiate between a normal Hive query and a DSL query ,
the proposal is to support DSL in the form

DOMAIN SELECT.........

Since the grammar hasnt been ported to GRILL yet, we have raised the pull
request here.

Thanks
Suma

On Mon, Nov 3, 2014 at 11:31 AM, sharadag [email protected] wrote:

User related DSL shouldn't be part of the Hive repo. Very soon we will get
away with the our forked Hive repo and will start depending on the
external
Hive releases.

On Mon, Nov 3, 2014 at 11:05 AM, Suma S [email protected] wrote:

Pls add a UT for this like we discussed..Before that pls discuss with
@Amareshwari https://github.com/Amareshwari if they are planning to
migrate the grammar soon?

—
Reply to this email directly or view it on GitHub
#55 (comment).

—
Reply to this email directly or view it on GitHub
#55 (comment).

---

The information contained in this communication is intended solely for the
use of the individual or entity to whom it is addressed and others
authorized to receive it. It may contain confidential or legally privileged
information. If you are not the intended recipient you are hereby notified
that any disclosure, copying, distribution or taking any action in reliance
on the contents of this information is strictly prohibited and may be
unlawful. If you have received this communication in error, please notify
us immediately by responding to this email and then delete it from your
system. The firm is neither liable for the proper and complete transmission
of the information contained in this communication nor for any delay in its
receipt.

[sumashivaprasad]

+Sharad

On Mon, Nov 3, 2014 at 12:15 PM, Suma Shivaprasad <
[email protected]> wrote:

Hi Sharad,

This pull request is to add a

DOMAIN clause to the grammar similiar to CUBE clause and this doesnt
include any USER DSL specific changes.

For GRILL to differentiate between a normal Hive query and a DSL query ,
the proposal is to support DSL in the form

DOMAIN SELECT.........

Since the grammar hasnt been ported to GRILL yet, we have raised the pull
request here.

Thanks
Suma

On Mon, Nov 3, 2014 at 11:31 AM, sharadag [email protected]
wrote:

User related DSL shouldn't be part of the Hive repo. Very soon we will
get
away with the our forked Hive repo and will start depending on the
external
Hive releases.

On Mon, Nov 3, 2014 at 11:05 AM, Suma S [email protected]
wrote:

Pls add a UT for this like we discussed..Before that pls discuss with
@Amareshwari https://github.com/Amareshwari if they are planning to
migrate the grammar soon?

—
Reply to this email directly or view it on GitHub
#55 (comment).

—
Reply to this email directly or view it on GitHub
#55 (comment).

---

The information contained in this communication is intended solely for the
use of the individual or entity to whom it is addressed and others
authorized to receive it. It may contain confidential or legally privileged
information. If you are not the intended recipient you are hereby notified
that any disclosure, copying, distribution or taking any action in reliance
on the contents of this information is strictly prohibited and may be
unlawful. If you have received this communication in error, please notify
us immediately by responding to this email and then delete it from your
system. The firm is neither liable for the proper and complete transmission
of the information contained in this communication nor for any delay in its
receipt.

[tintin2010]

@sumashivaprasad : As discussed raising a pull request for the UnitTest in GRILL codebase.

[ghost]

Are there changes in analyzers? Are you adding your own analyzer as part of domain?

Also on a side note, Please don't include InMobi JIRA issue numbers in the pull request, instead its better to copy description from the JIRA to the description of pull request.

[sumashivaprasad]

Each DSL will be parsed and rewritten through a DSL implementation . Please refer InMobi/grill#121 for more details .Grill will hand over the rewrite once it detects its a DSL. Here DSLCommand/DSLCommandImpl is the class which does this.

[ghost]

+1 for the code change
Have you run any hive tests for this?

[tintin2010]

@jdhok the unittest will be added to grill but we have run the following tests on the grammar https://github.corp.inmobi.com/user/domain-systems/blob/analytics/querylayer/grammar/src/test/java/org/apache/hadoop/hive/ql/parse/UserQLDriverTest.java