fix: Setup the dynamic import so it is separate from other packages #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default setup for dynamic import was such that the libraries would overlap with other libraries having the same names, which caused version mismatches when using the dynamic import version. This change makes the path separate. As well, it allows a named load for the library, which means the library can actually be used natively in the browser again, fixing issues with deployment standalone.
igoroctaviano
added a commit
that referenced
this pull request
May 9, 2024
…action is active (#117) * Fix opening of roi selection dialog * Add double click event * Revert "fix: Setup the dynamic import so it is separate from other packages (#113)" This reverts commit 2834944. * Lint * Improve event handling * Lint * Update event handling to avoid errors * Revert "Revert "fix: Setup the dynamic import so it is separate from other packages (#113)"" This reverts commit ddff79f. * CR updates
igoroctaviano
added a commit
to GitanjaliChhetri/dicom-microscopy-viewer
that referenced
this pull request
May 9, 2024
…other packages (ImagingDataCommons#113)"" This reverts commit f5abca9.
igoroctaviano
added a commit
that referenced
this pull request
May 9, 2024
… to the top level app (#85) * add-error-interceptor * Apply suggestions from code review Co-authored-by: Markus D. Herrmann <[email protected]> * Update documentation comments and add Error variables * add custom error class * fix linting errors * dummy commit to trigger actions workflow * update file name * Update PR * Update PR: Update signature * Lint * Revert "fix: Setup the dynamic import so it is separate from other packages (#113)" This reverts commit 2834944. * Fix enum * Revert "Revert "fix: Setup the dynamic import so it is separate from other packages (#113)"" This reverts commit f5abca9. --------- Co-authored-by: Markus D. Herrmann <[email protected]> Co-authored-by: Igor Octaviano <[email protected]>
moalsad
added a commit
to moalsad/icr-dicom-microscopy-viewer
that referenced
this pull request
Jun 9, 2024
Fix ImagingDataCommons#113 (Setup the dynamic import so it is separate from other packages) introduced issues with the PUBLIC_URL config.
igoroctaviano
added a commit
that referenced
this pull request
Jul 12, 2024
…notations support (#116) * Bump dcmjs, dicomweb-client and ol versions * Export utils * Only render polygons inside boundaries of viewport * Reload annotations on viewport changes * Address caching of bulk data annotations * Rollback annotations optimization * Improve for loop * Improve performance * Improve performance * Add multi layer support (auto replace) and basic color support * Remove test code * Use random points instead of centroids for points layer * Extract utils and allow selection of polygons * Run viewport checks only for polygons * Process annotations even if measurements request failed * Update workflow to use yarn * Bump actions * Update cache dependency path * Add lock file * Remove node 12x * Run linting * Use clusters * Extract style functions * Add point support alongisde polygon * Add 2d support * Remove unused cluster func * Unify geometry functions * Fix 2d and 3d annotation toggling * Add ellipse and rectangle * Fix ellispe rotation * Address array errors * Properly dispose layers to avoid memory leaks * Dispose overview map on cleanup function * Update open layers * Revert "Update open layers" This reverts commit a1829de. * Update cleanup function * Update condition for source clear * Improve error logging * Fix annotation group algorithm logic check * Add warnings for annotation group sequence index * Fix changing color of annotation disposing source issue and top left bottom right inverted * Fallback to p10 to retrieve coordinate and graphic index / render clusters with one feature * Change default color and width of polygons * Add support for polyline * Use right geometry for polyline * Calculate affine for right pyramid level * Render clusters if numberOfAnnotations is greater than 1000 * Refactor styles update for layers * Revert "fix: Setup the dynamic import so it is separate from other packages (#113)" This reverts commit 2834944. * Refactor cluster styles and fix shadowed clusters issue * feat: add reference series sequence tag (#126) * feat: add reference series sequence tag * fix: change to referencedSeriesInstanceUID * feat: add pointer move event (#128) * Update lock * Lint * Update tests --------- Co-authored-by: Pedro H. Köhler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default setup for dynamic import was such that the libraries would overlap with other libraries having the same names, which caused version mismatches when using the dynamic import version. This change makes the path separate. As well, it allows a named load for the library, which means the library can actually be used natively in the browser again, fixing issues with deployment standalone.