Add php action workflow #2309
Merged
Add php action workflow #2309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nilmerg: thanks! Is this ready to be merged? |
|
I would either immediately merge it or otherwise (in case this is still a work in progress) cherry-pick just the indentation fix |
|
These are only the style and lint tests. I planned to also add unit tests to this and drop travis. But if you want to merge it already, feel free to do it. |
nilmerg
force-pushed
the
add-php-action-workflow
branch
from
b6389b7
to
885a9ba
Compare
nilmerg
force-pushed
the
add-php-action-workflow
branch
2 times, most recently
from
febbc04
to
044fcfd
Compare
nilmerg
force-pushed
the
add-php-action-workflow
branch
from
47e1d80
to
8d0c851
Compare
|
|
nilmerg
force-pushed
the
add-php-action-workflow
branch
from
a6d8d43
to
48c4ae1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests are still missing