IcingaCloneObjectForm: Fix cloning of hosts in director branches (#2898)

The cloned host must also have services and service sets that are under the original host.
Icinga · Nov 7, 2024 · 0307409 · 0307409
2 parents d9b3b23 + 9d18663
commit 0307409
Showing 1 changed file with 15 additions and 3 deletions.
diff --git a/application/forms/IcingaCloneObjectForm.php b/application/forms/IcingaCloneObjectForm.php
@@ -148,7 +148,8 @@ public function onSuccess()
             $object->getObjectName()
         );
 
-        if ($object->isTemplate() && $this->branch && $this->branch->isBranch()) {
+        $isBranch = $this->branch && $this->branch->isBranch();
+        if ($object->isTemplate() && $isBranch) {
             throw new IcingaException('Cloning templates is not available for Branches');
         }
 
@@ -211,7 +212,11 @@ public function onSuccess()
                 );
 
                 if ($new instanceof IcingaHost) {
-                    $clone->set('host_id', $newId);
+                    if ($isBranch) {
+                        $clone->set('host', $newName);
+                    } else {
+                        $clone->set('host_id', $newId);
+                    }
                 } elseif ($new instanceof IcingaServiceSet) {
                     $clone->set('service_set_id', $newId);
                 }
@@ -222,7 +227,14 @@ public function onSuccess()
                 $newSet = IcingaServiceSet::fromPlainObject(
                     $set->toPlainObject(),
                     $connection
-                )->set('host_id', $newId);
+                );
+
+                if ($isBranch) {
+                    $newSet->set('host', $newName);
+                } else {
+                    $newSet->set('host_id', $newId);
+                }
+
                 $store->store($newSet);
             }