Commits on Nov 14, 2024

1. Use Checkable::GetStateBeforeSuppression() only where relevant …

   This fixes an issue where recovery notifications get lost if they happen
   outside of a notification time period.
   
   Not all calls to `Checkable::NotificationReasonApplies()` need
   `GetStateBeforeSuppression()` to be checked. In fact, for one caller,
   `FireSuppressedNotifications()` in
   `lib/notification/notificationcomponent.cpp`, the state before suppression may
   not even be initialized properly, so that the default value of OK is used which
   can lead to incorrect return values. Note the difference between suppressions
   happening on the level of the `Checkable` object level and the `Notification`
   object level. Only the first sets the state before suppression in the
   `Checkable` object, but so far, also the latter used that value incorrectly.
   
   This commit moves the check of `GetStateBeforeSuppression()` from
   `Checkable::NotificationReasonApplies()` to the one place where it's actually
   relevant: `Checkable::FireSuppressedNotifications()`. This made the existing
   call to `NotificationReasonApplies()` unneccessary as it would always return
   true: the `type` argument is computed based on the current check result, so
   there's no need to check it against the current check result.

   

   julianbrost authored and Al2Klimov committed Nov 14, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for e313b3f
   • Browse repository at this point

   Copy the full SHA

   e313b3f View commit details

   Browse the repository at this point in the history