Merge pull request #10224 from Icinga/Empty-constant

Make icinga::Empty constant to prevent accidental changes
Icinga · Nov 14, 2024 · d68ee3f · d68ee3f
2 parents 7a20d98 + 09160ea
commit d68ee3f
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/lib/base/object.hpp b/lib/base/object.hpp
@@ -27,7 +27,7 @@ class String;
 struct DebugInfo;
 class ValidationUtils;
 
-extern Value Empty;
+extern const Value Empty;
 
 #define DECLARE_PTR_TYPEDEFS(klass) \
 	typedef intrusive_ptr<klass> Ptr

diff --git a/lib/base/value.cpp b/lib/base/value.cpp
@@ -13,7 +13,7 @@ template const bool& Value::Get<bool>() const;
 template const String& Value::Get<String>() const;
 template const Object::Ptr& Value::Get<Object::Ptr>() const;
 
-Value icinga::Empty;
+const Value icinga::Empty;
 
 Value::Value(std::nullptr_t)
 { }

diff --git a/lib/base/value.hpp b/lib/base/value.hpp
@@ -149,7 +149,7 @@ extern template const bool& Value::Get<bool>() const;
 extern template const String& Value::Get<String>() const;
 extern template const Object::Ptr& Value::Get<Object::Ptr>() const;
 
-extern Value Empty;
+extern const Value Empty;
 
 Value operator+(const Value& lhs, const char *rhs);
 Value operator+(const char *lhs, const Value& rhs);