Skip to content

Commit

Permalink
Make protected SharedObject#~SharedObject() non-virtual
Browse files Browse the repository at this point in the history
`virtual`, which isn't for free, is only needed for a base method to redirect direct calls by pointer to an override if any. But this method is protected, so it's not called directly.
  • Loading branch information
Al2Klimov authored Nov 15, 2024
1 parent f3e7f19 commit 3639da9
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion lib/base/shared-object.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ class SharedObject
return *this;
}

inline virtual
~SharedObject() = default;

private:
Expand Down

0 comments on commit 3639da9

Please sign in to comment.