Add tasks to create icingadb-redis log directory #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Icinga's packages no longer create /var/log/icingadb-redis/ since logging moved to the journal by default. If logging to a file is needed, the according directory has to be created beforehand. Fixes #298
|
If I understand correctly we will "revert" the default logging method from icingadb-redis because we have a default set and the variable icingadb_redis_logfile isn't empty. In the config template I recognised the following, I guess within the next release we need to provide a switch to choose between these two options? Regarding the PR, this looks very good and I approve the changes. |
mkayontour
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Icinga's packages no longer create /var/log/icingadb-redis/ since logging moved to the journal by default. If logging to a file is needed, the according directory has to be created beforehand.
Fixes #298