-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: ADD roles/icingadb/tasks/install_on_suse.yml #233
WIP: ADD roles/icingadb/tasks/install_on_suse.yml #233
Conversation
Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA). Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA. After that, please reply here with a comment and we'll verify. Contributors that have not signed yet: @johanneskastl
|
fdfd371
to
c7fde6c
Compare
Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA). Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA. After that, please reply here with a comment and we'll verify. Contributors that have not signed yet: @johanneskastl
|
@cla-bot check |
Any opinions? |
What do you think about this, @mkayontour? Since this is an OS-related dependency, it'd feel wrong for me to list it as a 'general' dependency, though I don't know of any other way of doing this... |
Hey, the documentation on the galaxy.yml "metadata" is sparse. But as reading a few threads it seems, that the dependencies will be managed automatically if listed in galaxy.yml. I would recommend state it in the documentation to avoid the direct dependency for every OS. Create something like Known Issues or Install Requirements for Suse somewhere prominent, like Getting Started. |
The WIP looks fine to me, if you want to prepare a PR please make sure to add a changelog fragment. We described it here "https://github.com/Icinga/ansible-collection-icinga/blob/main/CONTRIBUTING.md" Thanks for your work! Appreciate it! |
Thanks for the hint. I'll add this to all of the open PRs on Wednesday (I hope...) |
Work continues in PR #273. |
AFAIK adding the Suse installation requires the
community.general.zypper
module (even though the task saysansible.builtin.package
).Should I add a
collections/requirements.yml
or a line in thegalaxy.yml
to make this visible?fix #231