Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: ADD roles/icingadb/tasks/install_on_suse.yml #233

Conversation

johanneskastl
Copy link
Contributor

@johanneskastl johanneskastl commented Dec 7, 2023

AFAIK adding the Suse installation requires the community.general.zypper module (even though the task says ansible.builtin.package).

Should I add a collections/requirements.yml or a line in the galaxy.yml to make this visible?

fix #231

Copy link

cla-bot bot commented Dec 7, 2023

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @johanneskastl

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

  • If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

@johanneskastl johanneskastl force-pushed the 20231206_add_Suse_support_icingadb_role branch from fdfd371 to c7fde6c Compare December 17, 2023 16:45
Copy link

cla-bot bot commented Dec 17, 2023

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @johanneskastl

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

  • If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

@bobapple
Copy link
Member

@cla-bot check

@cla-bot cla-bot bot added the cla/signed label Dec 18, 2023
@johanneskastl
Copy link
Contributor Author

Should I add a collections/requirements.yml or a line in the galaxy.yml to make this visible?

Any opinions?

@mocdaniel
Copy link
Contributor

What do you think about this, @mkayontour? Since this is an OS-related dependency, it'd feel wrong for me to list it as a 'general' dependency, though I don't know of any other way of doing this...

@mkayontour
Copy link
Member

Hey, the documentation on the galaxy.yml "metadata" is sparse. But as reading a few threads it seems, that the dependencies will be managed automatically if listed in galaxy.yml.

I would recommend state it in the documentation to avoid the direct dependency for every OS.

Create something like Known Issues or Install Requirements for Suse somewhere prominent, like Getting Started.

@mkayontour
Copy link
Member

The WIP looks fine to me, if you want to prepare a PR please make sure to add a changelog fragment.

We described it here "https://github.com/Icinga/ansible-collection-icinga/blob/main/CONTRIBUTING.md"

Thanks for your work! Appreciate it!

@johanneskastl
Copy link
Contributor Author

The WIP looks fine to me, if you want to prepare a PR please make sure to add a changelog fragment.

We described it here "https://github.com/Icinga/ansible-collection-icinga/blob/main/CONTRIBUTING.md"

Thanks for your work! Appreciate it!

Thanks for the hint. I'll add this to all of the open PRs on Wednesday (I hope...)

@mkayontour mkayontour mentioned this pull request Jan 17, 2024
8 tasks
@mkayontour
Copy link
Member

Work continues in PR #273.

@mkayontour mkayontour closed this Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

install_on_suse.yml not found for role icinga.icinga.icingadb
4 participants