Fix rules with slash not working on Windows #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I assume that optionator parses strings as file names, so on Windows it turns slashes into backslashes.
|
Hi, thanks for the PR! Can you give an example of a rule name that currently fails in windows? This package is used in https://github.com/IanVS/eslint-nibble, and I haven't heard any reports of windows failures, so I'd like to make sure I clearly understand what is going on. |
|
Hi, I did some more research and it actually seems to be related to So I assume this fix isn't strictly needed, since your code is working as intended, but maybe a disclaimer on the readme or the like... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I assume that optionator parses strings as file names (as there's a similar bug reported here), so on Windows it turns slashes in rule names into backslashes.
I haven't encountered rules that contain spaces, so this may be enough to fix related issues for now.