Added exception for when the maintainer group is not created #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algomaster99
requested changes
Oct 6, 2020
views/maintainer_group.py
Outdated
| @@ -7,6 +7,8 @@ | |||
| MaintainerGroupSerializer, | |||
| ) | |||
|
|
|||
| from django.core.exceptions import ObjectDoesNotExist | |||
There was a problem hiding this comment.
This is a top-level import. Shift this to line number 2.
views/maintainer_group.py
Outdated
| @@ -25,3 +27,5 @@ def get_object(self, *args, **kwargs): | |||
| return MaintainerGroup.objects.get(pk=1) | |||
| except IndexError: | |||
| raise Http404 | |||
| except ObjectDoesNotExist: | |||
There was a problem hiding this comment.
Use MainatainerGroup.DoesNotExists. And remember to delete the import statement.
views/maintainer_group.py
Outdated
| @@ -25,3 +27,5 @@ def get_object(self, *args, **kwargs): | |||
| return MaintainerGroup.objects.get(pk=1) | |||
| except IndexError: | |||
There was a problem hiding this comment.
I don't know why I added this but now I think it might be unnecessary.
|
Commit message is started with present tense. - |
…nd remove Index Error exception
…nd remove Index Error exception
algomaster99
approved these changes
Oct 8, 2020
|
Will merge once IMGIITRoorkee/omniport-frontend-maintainer-site#25 is resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error 404 is raised instead of 500